Hello @Xel-Naha thanks for opening this PR - could you please look at adding some test to make sure we capture this in our CI? If you need pointers let me know!

Hello @Xel-Naha thanks for opening this PR - could you please look at adding some test to make sure we capture this in our CI? If you need pointers let me know!

hi @gmuloc happy to write a test but some pointers would certainly be helpful,

CodSpeed Performance Report

Merging #842 will not alter performance

_{Comparing Xel-Naha:main (b654ce1) with main (fc644a1)}

Summary

✅ 4 untouched benchmarks

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hi @gmuloc, I just had a look at the failing test and I don't think this is any issue with the code (after all its a minor modification from existing code) however the pipeline seems to have issues downloading something:

__getitem__
    raise KeyError(key) from None
KeyError: 'SSS_SERVICE_URL'
Error: Process completed with exit code 1.
Run cat ./target/job_summary.md >> $GITHUB_STEP_SUMMARY
cat: ./target/job_summary.md: No such file or directory
Error: Process completed with exit code 1.

i'm suspecting it might be something that needs reviewing on your end?

hi @gmuloc, I just had a look at the failing test and I don't think this is any issue with the code (after all its a minor modification from existing code) however the pipeline seems to have issues downloading something:

__getitem__
    raise KeyError(key) from None
KeyError: 'SSS_SERVICE_URL'
Error: Process completed with exit code 1.
Run cat ./target/job_summary.md >> $GITHUB_STEP_SUMMARY
cat: ./target/job_summary.md: No such file or directory
Error: Process completed with exit code 1.

i'm suspecting it might be something that needs reviewing on your end?

yeah its on our side we need to check with people maintaining this service internally.
we will merge as soon as we can